Closed
Bug 1234238
Opened 8 years ago
Closed 8 years ago
Restore FFB theme
Categories
(Firefox for Android Graveyard :: Family Friendly Browsing, defect)
Tracking
(firefox45 fixed, firefox46 fixed, fennec45+)
RESOLVED
FIXED
Firefox 46
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
In bug 1222381 we removed the custom theme for FFB, expecting that we would have a theme picker. But we don't. So let's add back the custom theme.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28819/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28819/
Attachment #8700870 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8700870 [details] MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28819/diff/1-2/
Comment 3•8 years ago
|
||
Comment on attachment 8700870 [details] MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian https://reviewboard.mozilla.org/r/28819/#review25659
Attachment #8700870 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/47cba7f5e4fe95a44465305241f745c0905ef02b Bug 1234238 - Restore FFB theme. r=sebastian
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/47cba7f5e4fe
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8700870 [details] MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian Approval Request Comment [Feature/regressing bug #]: Bug 1222381. [User impact if declined]: FFB theme will be missing in restricted profiles. [Describe test coverage new/current, TreeHerder]: Tested manually. [Risks and why]: Low-risk, only affects restricted profiles. [String/UUID change made/needed]: None.
Attachment #8700870 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox45:
--- → affected
Updated•8 years ago
|
Attachment #8700870 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I'm hitting conflicts trying to uplift this to aurora. Can we get a rebased patch?
Flags: needinfo?(margaret.leibovic)
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0b0ad49b4317
Flags: needinfo?(margaret.leibovic)
Updated•6 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•