1234279 - old revision of diff in MozReview links to current revision of diff in Mercurial, instead of old revision

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: Extension, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As part of re-reviewing a patch that I'd previously reviewed (and not granted review), I wanted to look at the version that I'd reviewed before (and the review comments I made on that version).

So I went to https://reviewboard.mozilla.org/r/24415/diff/13/ and looked at the pull and import links on the right side -- and got a result that didn't make sense.  It turns out that it didn't make sense because those pull and import links are showing the same data that https://reviewboard.mozilla.org/r/24415/diff/23/ is showing, i.e., they're showing the revision information for the current version of the patch (which is actually an entirely different patch due to bad patch correlation) rather than the old revision of the patch that I'm looking at.

I think this should instead be showing the data corresponding to the version of the diff being viewed (perhaps with a note that it's not the current revision, in case anyone is expecting the current behavior).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I've now denied review requests due to this bug (bug 1229437 comment 29).  I will be asking reviewers not to post reviews in MozReview going forward.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, the workaround is the well-hidden "Download Diff" link at the top next to "Finish Review".

Comment 3

[Gregory Szorc [:gps]]

mdoglio: can you look into this?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suspect this is a similar bug to bug 1296135, and perhaps a similar warning would make sense?

Comment 6

[:glob ✱]

bug 1309964 is touching this part of the ui.  once that's landed i'll look into updating the pull and import text fields when the interdiff sliders are updated.

Comment 7

[Karl Tomlinson (:karlt)]

The review summary has links to the changesets in https://reviewboard-hg.mozilla.org/gecko/ but getting to the review summary is difficult if the child has been discarded (bug 1286000).

Comment 8

[Karl Tomlinson (:karlt)]

(In reply to Karl Tomlinson (:karlt) from comment #7)
> The review summary has links to the changesets in
> https://reviewboard-hg.mozilla.org/gecko/

but this can be confusing because the revision numbers in the review summary don't match the child revision numbers.

Comment 9

[:glob ✱]

sorry, i don't have time to look at this right now :(

Comment 10

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.