1234733 - Incorrect locale language tag in Honeycomb EOL url

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

We should use Locales.getLanguageTag(Locale.getDefault()) instead of just Locale.getDefault() in the Honeycomb EOL message.

Comment 1

[:Margaret Leibovic]

I see this isn't an issue for the other SUMO URLs we format from Java:
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#l851
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#l3373

Maybe we need to move the logic to format these links into some sort of helper method so that we don't make this mistake again.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Review commit: https://reviewboard.mozilla.org/r/28973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28973/

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

https://reviewboard.mozilla.org/r/28973/#review25735

Comment 4

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/28973/#review25737

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/14aea198d5b18b4850801a23c61cbd066bf93f4f
Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Comment 6

[:Margaret Leibovic]

Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Bug 1220720.

[User impact if declined]: EOL honeycomb message points to wrong URL.

[Describe test coverage new/current, TreeHerder]: No automated tests. I didn't test this locally because I don't have a Honeycomb device, but Chenxia will be testing this.

[Risks and why]: Low-risk, URL change.

[String/UUID change made/needed]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14aea198d5b1

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

let's try that.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed8fe7294c30