Closed Bug 1234854 Opened 8 years ago Closed 8 years ago

Upgrade secrets to use new config, new loader

Categories

(Taskcluster :: Services, defect)

Product:
Taskcluster
Component:
Services
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

https://github.com/taskcluster/taskcluster-secrets/pull/12
58 bytes, text/x-github-pull-request
jhford
: review+
Details | Review 
The loader will make DI a bit easier for testing.
Comment on attachment 8714571 [details] [review]
https://github.com/taskcluster/taskcluster-secrets/pull/12

The config/loader parts of this are great, r+.  Thanks for updating this, it looks great!
Attachment #8714571 - Flags: review?(jhford) → review+
deployed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Secrets → Services
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: