1235099 - Remove the NS_APP_BOOKMARKS_50_FILE directory service key

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mike Hommey [:glandium]]

Nothing in mozilla-central uses the NS_APP_BOOKMARKS_50_FILE/BMarks key except tests. It's also not been very useful since the switch to places in ... Firefox 3? so even if addons use it, it's not doing them much good. BookmarkHTMLUtils.defaultPath returns the same thing anyways for those that really do insist on getting the equivalent thing (but I'd argue BookmarkHTMLUtils.defaultPath, as well as the browser.bookmarks.file pref could just go away as well).

Seamonkey does use NS_APP_BOOKMARKS_50_FILE/BMarks, but they really only need the #define, which they can add in their source.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove the NS_APP_BOOKMARKS_50_FILE directory service key

Comment 2

[Justin Dolske [:Dolske]]

Err, did you attach the right patch? It doesn't touch NS_APP_BOOKMARKS_50_FILE at all.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Remove the NS_APP_BOOKMARKS_50_FILE directory service key

That was, indeed, the wrong patch.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91267331f36f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91267331f36f

Comment 6

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected