1235405 - "Clear Search" string note needs improvement

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

Added in https://github.com/mozilla/firefox-ios/commit/29fdc5907b358c050c193b381f65f8b3efa13f9a#diff-5cc03b4c973dda33230e94c658a77d9eR61

Without actually reading a patch it is not clear what "Clear Search" string represents and how it should be translated.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: clear_search.png

Sorry about this - I don't think this was part of the strings landing last Monday.

This string is used for VoiceOver to tell the user about the 'X' button in the search field. Tapping the 'X' will erase the typed input and close searching. See the attached image for the behaviour.

What are your thoughts on a better description?

Comment 2

[Stefan Plewako [:stef]]

(In reply to Stephan Leroux [:sleroux] from comment #1)
> Sorry about this - I don't think this was part of the strings landing last
> Monday.

I'm not sure what you mean by that, it was merged to master on December 16 in https://github.com/mozilla/firefox-ios/pull/1338

> This string is used for VoiceOver to tell the user about the 'X' button in
> the search field. Tapping the 'X' will erase the typed input and close
> searching. See the attached image for the behaviour.
> 
> What are your thoughts on a better description?

Maybe something similar to other notes for VoiceOver strings describing not only the effects (search clearing) but also element (VoiceOver command). Try searching for VoiceOver on https://github.com/splewako/firefox-ios-l10n-en/blame/master/en.xliff

Comment 3

[Stephan Leroux [:sleroux]]

Ah makes sense. How about:

'Accessibility message e.g. spoken by VoiceOver after the user taps the close button in the search field to clear the search and exit search mode'

Comment 4

[Stefan Plewako [:stef]]

(In reply to Stephan Leroux [:sleroux] from comment #3)
> Ah makes sense. How about:
> 
> 'Accessibility message e.g. spoken by VoiceOver after the user taps the
> close button in the search field to clear the search and exit search mode'

Much better.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1388

Comment 6

[Stefan Plewako [:stef]]

Comment on attachment 8702647 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1388

I'm not reviewer but the updated comment sounds clear enough for me.

Comment 7

[Stephan Leroux [:sleroux]]

master 4f060b3c479d1241fa597ec32b65c075d0c71de3