Closed Bug 1235636 Opened 8 years ago Closed 8 years ago

PCToLineNumber incorrectly resets column number

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file, 1 obsolete file)

rewrite PCToLineNumber
4.45 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
I found this while working on bug 1013219 and I'm breaking it out
into a separate bug for clarity.

The bug is that PCToLineNumber conditionally updates the line number,
but unconditionally clears the column number.  This means that in some
cases the column number is incorrect.
Blocks: 1013219
Attached patch rewrite PCToLineNumber (obsolete) — — Splinter Review 
The patch.

Nick r+'d the basic idea in the other bug but I will re-request review
since I've updated some tests.
Found one more regression from this.
Attachment #8702683 - Attachment is obsolete: true
Comment on attachment 8703016 [details] [diff] [review]
rewrite PCToLineNumber

Here's the PCToLineNumber patch separated out.
It cleans up a few mysterious column number choices in the tests.

You've already ok'd the original patch; not sure if you are able
to review the test fixes as well?
Attachment #8703016 - Flags: review?(nfitzgerald)
Attachment #8703016 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/9d5029646b52
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: