1235676 - Add a topobjdir variable to all Makefiles

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We have, all over the tree, several places that want absolute paths to the object directory, and most rely on things like $(abspath $(DIST)) or $(abspath $(DEPTH)), sometimes relying on even more complex things for windows paths. The sad part is that we do have the absolute path to the top object directory in the backend code (and in a proper form for windows, at that), we're just not exposing it to make.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add a topobjdir variable to all Makefiles

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add a global ABS_DIST variable for a non-relative version of DIST, based on topobjdir

This replaces multiple local definitions of ABS_DIST.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Replace _ABS_DIST with ABS_DIST

Comment 4

[Mike Hommey [:glandium]]

Attachment: Replace $(abspath $(DIST)) with $(ABS_DIST)

Comment 5

[Mike Hommey [:glandium]]

Attachment: Replace $(abspath $(DEPTH)) with $(topobjdir)

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] (VAC: 31 Dec - 11 Jan) from comment #5)
> Created attachment 8702762 [details] [diff] [review]
> Replace $(abspath $(DEPTH)) with $(topobjdir)

Note there's a remaining one in xulrunner/installer/windows/Makefile.in, but it's removed in bug 1235672

Comment 7

[Mike Hommey [:glandium]]

Attachment: test_recursivemake.py update for topobjdir

This is to be folded in the first patch.

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8702757 [details] [diff] [review]
Add a topobjdir variable to all Makefiles

Everything looks good to me. Did you test with an OSX universal build? That's the only place I can imagine something biting us.

Comment 9

[Michael Shal [:mshal]]

Comment on attachment 8702796 [details] [diff] [review]
test_recursivemake.py update for topobjdir

This should probably be folded in with the first patch.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/241e21132790
https://hg.mozilla.org/integration/mozilla-inbound/rev/63a73122425a
https://hg.mozilla.org/integration/mozilla-inbound/rev/74f9a758dbc2
https://hg.mozilla.org/integration/mozilla-inbound/rev/294f8f6ae9e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/567f190c8597

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/241e21132790
https://hg.mozilla.org/mozilla-central/rev/63a73122425a
https://hg.mozilla.org/mozilla-central/rev/74f9a758dbc2
https://hg.mozilla.org/mozilla-central/rev/294f8f6ae9e0
https://hg.mozilla.org/mozilla-central/rev/567f190c8597