Closed Bug 1235799 Opened 8 years ago Closed 8 years ago

Intermittent TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_edit_test.js | Homescreen - Pinned Site Edit "before each" hook for "pressing enter after renaming the pinned site"

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: mikehenrty, Assigned: gmarty)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_edit_test.js | Homescreen - Pinned Site Edit "before each" hook for "pressing enter after renaming the pinned site"
ElementNotVisible: ElementNotVisible: Element is not visible
Remote Stack:
<none>
    at Error.MarionetteError (node_modules/marionette-client/lib/marionette/error.js:105:13)
    at Object.Client._handleCallback (node_modules/marionette-client/lib/marionette/client.js:529:19)
    at Object.<anonymous> (node_modules/marionette-client/lib/marionette/client.js:572:23)
    at TcpSync.sendRaw (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:226:10)
    at TcpSync.sendMessage (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:209:15)
    at TcpSync.send (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:190:17)
    at Object.send (node_modules/marionette-client/lib/marionette/client.js:492:34)
    at Object.Client._sendCommand (node_modules/marionette-client/lib/marionette/client.js:553:21)
    at Object.Element._sendCommand (node_modules/marionette-client/lib/marionette/element.js:51:32)
    at Object.click (node_modules/marionette-client/lib/marionette/element.js:176:19)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:76:24)
    at Context.<anonymous> (apps/homescreen/test/marionette/pinning_edit_test.js:38:13)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)


https://treeherder.mozilla.org/logviewer.html#?job_id=3241320&repo=gaia
Assignee: nobody → gmarty
Target Milestone: --- → 2.6 S5 - 1/15
Comment on attachment 8706393 [details] [review]
[gaia] gmarty:Bug-1235799-intermittent-pinning_edit_test > mozilla-b2g:master

I believe this test is now more stable thanks to the changes in waitForLaunch().
No failures in ~50 tries.
Attachment #8706393 - Flags: review?(chrislord.net)
Comment on attachment 8706393 [details] [review]
[gaia] gmarty:Bug-1235799-intermittent-pinning_edit_test > mozilla-b2g:master

LGTM. Probably worth changing the commit message for the same reason stated in bug 1233527.
Attachment #8706393 - Flags: review?(chrislord.net) → review+
Landed in https://github.com/mozilla-b2g/gaia/commit/81de7510cd03e5cfc506e9479035d66adbaacf3b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: