Closed
Bug 123580
Opened 23 years ago
Closed 23 years ago
[FIX]about: protocol directory needs clean up
Categories
(SeaMonkey :: General, defect, P2)
SeaMonkey
General
Tracking
(Not tracked)
CLOSED
FIXED
mozilla0.9.9
People
(Reporter: alexeyc2003, Assigned: bzbarsky)
Details
Attachments
(1 file)
21.84 KB,
patch
|
leaf
:
review+
|
Details | Diff | Splinter Review |
According to bug 68086, the following files should be removed from mozilla/netwerk/protocol/about/src/ mzAboutMozilla.cpp mzAboutMozilla.h nsAboutCredits.cpp nsAboutCredits.h nsAboutPlugins.cpp nsAboutPlugins.h Some of these files are still referenced by nsAboutProtocolModule.cpp However I could not find references to this file itself, so maybe it should be removed as well, I'm not sure.
Assignee | ||
Comment 2•23 years ago
|
||
Zach, would you be willing to make the mac build changes necessary for this, if any?
Assignee | ||
Updated•23 years ago
|
Priority: -- → P2
Summary: about: protocol directory needs clean up → [FIX]about: protocol directory needs clean up
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 3•23 years ago
|
||
Tested on Linux, I've asked Zach to test on Mac.
Comment 4•23 years ago
|
||
Tested on mac, all is ok
Assignee | ||
Comment 5•23 years ago
|
||
leaf? The patch builds on Linux/Mac. Visual inspection shows the files are not referenced no Win. Would you review?
Comment 6•23 years ago
|
||
Comment on attachment 68086 [details] [diff] [review] Patch removing the dead files. looks good, verified that about: urls still work without these files :)
Attachment #68086 -
Flags: review+
a=roc+moz for 0.9.9
Updated•23 years ago
|
Keywords: mozilla0.9.9+
Assignee | ||
Comment 8•23 years ago
|
||
Files removed on trunk (pre-branch, so this made 0.9.9 :) ).
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•