Closed
Bug 1235893
Opened 8 years ago
Closed 8 years ago
Do not approve suggestions automatically
Categories
(Webtools Graveyard :: Pontoon, defect, P2)
Webtools Graveyard
Pontoon
Tracking
(firefox46 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | affected |
People
(Reporter: gion-andri, Unassigned)
Details
If a string has two unapproved suggestions and one of them is deleted, the other one is automatically approved. This happens quite often, when making suggestions and having to delete a suggestion containing an error. I think Pontoon should not automatically approve any suggestions if a user is in suggestion-mode.
Updated•8 years ago
|
Priority: -- → P2
Comment 1•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/pontoon https://github.com/mozilla/pontoon/commit/e71472d5f2b089fdcf68138d9e49bdbdd6221916 Fix bug 1235893: Don't approve suggestions on delete Do not automatically approve next translation when deleting the active one. Not just when in suggest mode like the bug description suggests, but in general. Automatic approval is dangerous and from now on we require localizers to explicitly approve one of the remaining suggestions. To avoid any surprises. https://github.com/mozilla/pontoon/commit/c18ac77056fc98d2757776a78be95d195f6b8fd0 Merge pull request #327 from mathjazz/bug-1235893-do-not-approve-automatically Fix bug 1235893: Don't approve suggestions on delete
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•