Closed
Bug 1236052
Opened 8 years ago
Closed 8 years ago
Fix comment in DebuggerClient.prototype.connect
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
The comment talks about DebuggerServer, but the code is using DebuggerClient. I think the comment was a typo, but will ask the original author to confirm.
|
Assignee | |
Comment 1•8 years ago
|
||
Honza, can you confirm whether this comment should say DebuggerClient?
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8703162 [details] [diff] [review] Bug1236052.patch Review of attachment 8703162 [details] [diff] [review]: ----------------------------------------------------------------- You are right the comment is now fixed, thanks! Honza
Attachment #8703162 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4ef357c91657
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 5•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•