Closed
Bug 1236091
Opened 8 years ago
Closed 8 years ago
Null check in BlitFramebuffer
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
We trigger this during deqp/functional/gles3/framebufferblit.html
|
Assignee | |
Updated•8 years ago
|
Attachment #8703200 -
Attachment is patch: true
Attachment #8703200 -
Attachment mime type: text/x-patch → text/plain
Attachment #8703200 -
Flags: review?(jgilbert)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8703200 [details] [diff] [review] Null check in BlitFramebuffer Review of attachment 8703200 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGL2ContextFramebuffers.cpp @@ +118,5 @@ > return; > } > > + if (mBoundReadFramebuffer && !mBoundReadFramebuffer->ValidateAndInitAttachments("blitFramebuffer's READ_FRAMEBUFFER") || > + mBoundDrawFramebuffer && !mBoundDrawFramebuffer->ValidateAndInitAttachments("blitFramebuffer's DRAW_FRAMEBUFFER")) Should really just move these down into their respective branches below.
Attachment #8703200 -
Flags: review?(jgilbert) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/af2a9677e580
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
|
||
Updated•8 years ago
|
Assignee: nobody → jmuizelaar
You need to log in
before you can comment on or make changes to this bug.
Description
•