Closed
Bug 1236118
Opened 8 years ago
Closed 8 years ago
Complete test coverage for the WebExtension cookies API.
Categories
(WebExtensions :: Untriaged, defect, P3)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: kmag, Assigned: bsilverberg)
References
Details
(Whiteboard: [test] triaged)
Attachments
(1 file)
There's a lot of missing coverage in the |query| function, in particular: * Selecting an enumerator for queries with no |url| or |domain| filter. * Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters. * Non-matching cookies for the domain and path portions of the |url| filter. * Failing |checkSetCookiePermissions| checks for cross-domain cookies. * |cookies.set| calls with an explicit |path| or |httpOnly| value. * |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|. * |cookies.set| calls for session cookies. * Cookie eviction events for expired cookies. https://people.mozilla.org/~kmaglione/webextension-test-coverage/toolkit/components/extensions/ext-cookies.js.html
Updated•8 years ago
|
Flags: blocking-webextensions?
Priority: -- → P3
Whiteboard: [test] triaged
Updated•8 years ago
|
Flags: blocking-webextensions? → blocking-webextensions+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
Iteration: --- → 48.1 - Mar 21
Assignee | ||
Comment 1•8 years ago
|
||
Add coverage for: * checkSetCookiePermissions for invalid scheme and failing checks for cross-domain cookies. * |query| - Selecting an enumerator for queries with no |url| or |domain| filter. * |query| - Matching and non-matching cookies for the |domain|, |path|, |secure|, |session|, and |storeId| filters. * |query| - Non-matching cookies for the domain and path portions of the |url| filter. * |cookies.set| calls with an explicit |path| or |httpOnly| value. * |cookies.set| calls without an explicit |name|, |value|, or |expirationDate|. Review commit: https://reviewboard.mozilla.org/r/39273/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39273/
Attachment #8729169 -
Flags: review?(kmaglione+bmo)
Reporter | ||
Updated•8 years ago
|
Attachment #8729169 -
Flags: review?(kmaglione+bmo) → review+
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8729169 [details] MozReview Request: Bug 1236118 - Complete test coverage for the WebExtension cookies API, r?kmag https://reviewboard.mozilla.org/r/39273/#review36057
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=daea8b51f3aa
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/93f0785edcc7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•