1236137 - Autoland includes r=foo marker even if message already has it

Status: RESOLVED WORKSFORME

(Conduit Graveyard :: Transplant, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Autoland appends an "r=REVIEWER" marking on the first line of the commit message even if the commit message already includes a manually added r=… line.

I’d expect Autoland to first look for a reviewer annotation line and if it finds one, verify that it is correct.  Only if one cannot be found, a new line is added.

Example of a commit with double r=… marking: http://hg.mozilla.org/integration/mozilla-inbound/rev/17576c804d39

Comment 1

[Dan Minor [:dminor]]

We only look at the first line of the commit message. In this case your patch had r=gps on a subsequent line of the patch, so it was not examined. I think putting the reviewers on the first line of the commit message is standard practice (at least for mozilla-central) so I don't think we'll change this behaviour.

Comment 2

[Andreas Tolfsen ❲:ato❳]

The commit rules puts no restrictions on whether the r=… annotation is on the first line of the commit message.  When you add further metadata to the commit message, it is inconvenient for the first line to hold all such annotations.

    https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities

Either we need to scan the all the lines of the commit message, or the commit rules needs to be adapted to match Autoland’s idiosyncrasies.