Closed Bug 1236443 Opened 8 years ago Closed 8 years ago

[TV][2.5] App window & preview window support back navigation

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(feature-b2g:2.5+, b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(1 file)

[gaia] rickychien:backNavigation > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review 
We should offer ability to navigate back when user is navigating in app window and preview window and also close preview window if user hits the landing page.
Summary: App window & preview window support back navigation → [TV][2.5] App window & preview window support back navigation
In the case of routing from app:// protocol to http(s):// protocol, we only provide goBack() when user is browsing in http(s):// not for app:// protocol. App and app:// will not be killed by back key.
Comment on attachment 8703605 [details] [review]
[gaia] rickychien:backNavigation > mozilla-b2g:master

Luke, I hope that I don't misunderstand or miss some cases for supporting back key navigation feature. Please review it kindly thanks!
Attachment #8703605 - Flags: review?(lchang)
Comment on attachment 8703605 [details] [review]
[gaia] rickychien:backNavigation > mozilla-b2g:master

Looks good! Thanks.
Attachment #8703605 - Flags: review?(lchang) → review+
Landed.

https://github.com/mozilla-b2g/gaia/commit/ac74a094d01052830fbd42e3721b2118d65a02d6

thank you Luke!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8703605 [details] [review]
[gaia] rickychien:backNavigation > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature of bug 1211400
[User impact] if declined: n/a
[Testing completed]: manual verified on local
[Risk to taking this patch] (and alternatives if risky): impact on app window management
[String changes made]:
Attachment #8703605 - Flags: approval-gaia-v2.5?
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
Comment on attachment 8703605 [details] [review]
[gaia] rickychien:backNavigation > mozilla-b2g:master

Approve for TV 2.5
Attachment #8703605 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: