1236507 - DownloadContentService: Skip download if file system is not writable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Skip trying to download things if the file system is not writable (temporary file or destination file).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1236507 - DownloadContentService: Skip download if file system is not writable. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/29407/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29407/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8703594 [details]
MozReview Request: Bug 1236507 - DownloadContentService: Skip download if file system is not writable. r?rnewman

https://reviewboard.mozilla.org/r/29407/#review26321

::: mobile/android/base/java/org/mozilla/gecko/dlc/DownloadAction.java:90
(Diff revision 1)
> +                if (!canWrite(temporaryFile, destinationFile)) {

If the destination file isn't writeable, should this be recoverable?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Richard Newman [:rnewman] from comment #2)
> If the destination file isn't writeable, should this be recoverable?

With failure counters: Yeah, if it's repeatable then we will stop trying. I can't really come up with a "normal user" reason why the destination file (which is inside the app directory for now) is not writable. This should be almost never be the case.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/61b71f449adc8a325cbc22dbf325f160d7975e52
Bug 1236507 - DownloadContentService: Skip download if file system is not writable. r=rnewman

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> I can't really come up with a "normal user" reason why the destination file
> (which is inside the app directory for now) is not writable. This should be
> almost never be the case.

And ... booom, I'm seeing this on a Genymotion emulator now. I filed bug 1236907 to investigate.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/61b71f449adc