1236578 - "Select your Add-ons" dialog shows Hello and Pocket

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Helmer [:rhelmer]]

Over the weekend I noticed that on my personal laptop (Ubuntu running Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They both indicate that they are installed by "You".

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #0)
> Over the weekend I noticed that on my personal laptop (Ubuntu running
> Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They
> both indicate that they are installed by "You".

Do you know how to trigger this dialog, for QA purposes? If we have a test for this dialog it should be pretty easy to test for this and make sure these are hidden there I'd guess, but I am not sure how to make this come up through normal browsing (pretty sure I was using an older profile when I triggered this initially).

Comment 2

[Dave Townsend [:mossop]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> (In reply to Robert Helmer [:rhelmer] from comment #0)
> > Over the weekend I noticed that on my personal laptop (Ubuntu running
> > Nightly) the "Select Your Add-ons" dialog shows both Hello and Pocket. They
> > both indicate that they are installed by "You".
> 
> Do you know how to trigger this dialog, for QA purposes? If we have a test
> for this dialog it should be pretty easy to test for this and make sure
> these are hidden there I'd guess, but I am not sure how to make this come up
> through normal browsing (pretty sure I was using an older profile when I
> triggered this initially).

When upgrading to a new Firefox (extensions.lastAppVersion is different) we check extensions.shownSelectionUI and if that isn't true we show the UI. You must have been upgrading from a very old profile, we implemented this some time ago. Happily we do have automated tests for this! See browser_select_* here https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser

Comment 3

[Dave Townsend [:mossop]]

We have deleted this UI

Comment 4

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

Since we're not taking bug 1244302 in beta we should have this on release driver's radar. We could potentially do a smaller patch to hide these add-ons though even that would likely be harder than what bug 1244302 does.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Tracking as it is confusing.
Dave, are you going to implement the change? Thanks

Comment 6

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

Review commit: https://reviewboard.mozilla.org/r/35155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35155/

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

https://reviewboard.mozilla.org/r/35155/#review31725

::: toolkit/mozapps/extensions/content/selectAddons.js:79
(Diff revision 1)
> +        if (aAddon.type == "plugin" || aAddon.type == "service") {

I prefer always using braces so fine w/ me, but just wondering why this change in this patch?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Did this land on m-c ?
If so we should uplift it to aurora and beta.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Did this land on m-c ?
> If so we should uplift it to aurora and beta.

Sorry this slipped off my radar. This can't land on m-c or aurora since this problem was already fixed there by bug 1244302. This is a beta only patch.

Approval Request Comment
[Feature/regressing bug #]: System add-ons
[User impact if declined]: Users may accidentally disable system add-ons
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low risk just hides certain add-ons from the UI
[String/UUID change made/needed]: None

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Sylvestre maybe this can make it in time for beta 10? Looks like we do need it in 45

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8719874 [details]
MozReview Request: Bug 1236578: Don't display hidden add-ons in the select your add-ons UI. r?rhelmer

OK, approved. Too bad this is coming that late in the cycle :(
might be in 45 beta 10

Comment 12

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3eaf4e1122e7

Comment 13

[Andrei Vaida [:avaida]]

Assigning this to Bogdan, in terms of QA, since it might impact the Hello user experience.

Comment 14

[Paul Silaghi, QA [:pauly]]

Reproduced the issue on Nightly 2016-01-05, Win 7, by setting "extensions.lastAppVersion" to a lower version and "extensions.shownSelectionUI"=FALSE and then restarting Firefox.
On Fx 45b10, "Select your Add-ons" dialog no longer shows Hello and Pocket.
On Fx 46.0a2 (2016-02-24) and 47.0a1 (2016-02-24) the selection UI is completely gone.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Should the selection UI be gone completely as described in comment 14?

Comment 16

[Dave Townsend [:mossop]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #15)
> Should the selection UI be gone completely as described in comment 14?

Yes (bug 1244302)