Closed
Bug 1236754
Opened 8 years ago
Closed 8 years ago
e10s beta experiment uses incorrect prefs
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 46
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(2 files)
2.05 KB,
patch
|
mconley
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.70 KB,
patch
|
mconley
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I was looking into why tests are failing on beta and I noticed that a number of important prefs are still gated on E10S_TESTING_ONLY, which is disabled on beta: extensions.interposition.enabled extensions.interposition.prefetching dom.compartment_per_addon dom.ipc.plugins.asyncInit.enabled So, on beta, the people with e10s enabled are not getting any add-on shims and they're getting async plugin init (which is still broken in e10s AFAIK).
Assignee | ||
Comment 1•8 years ago
|
||
Actually, it looks like async plugin init is unconditionally disabled on beta.
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
tracking-e10s:
--- → ?
Assignee | ||
Comment 2•8 years ago
|
||
In the meeting we decided we'll have these prefs ride the trains with 45.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → wmccloskey
Assignee | ||
Comment 3•8 years ago
|
||
Actually, we decided to get this change into 44 so that we can still get some data out of the next beta.
Attachment #8704371 -
Flags: review?(mconley)
Comment 4•8 years ago
|
||
Comment on attachment 8704371 [details] [diff] [review] fix-shims Review of attachment 8704371 [details] [diff] [review]: ----------------------------------------------------------------- I assume we've evaluated the potential for increased memory usage from the new compartments, as well as increased overhead over the interposition layer, and are okay with it? If so, r=me.
Attachment #8704371 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Sorry, Mike. Now they want us to enable this stuff only for people with e10s. It turns out that the compartment_per_addon pref is already enabled if you have e10s: https://dxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCWrappedNativeScope.cpp#239 And the prefetching pref can be enabled unconditionally since the prefetcher is only used if shims are already enabled. I change each callsite that uses extensions.interposition.enabled so that it also checks BrowserTabsRemoteAutostart.
Attachment #8704440 -
Flags: review?(mconley)
Assignee | ||
Comment 6•8 years ago
|
||
By the way, we want to get this into the beta, which builds tomorrow.
Comment 7•8 years ago
|
||
Gotcha - reviewing now.
Comment 8•8 years ago
|
||
Comment on attachment 8704440 [details] [diff] [review] change-default Review of attachment 8704440 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - let's roll.
Attachment #8704440 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8704440 [details] [diff] [review] change-default This is the patch we want to take on beta so that the e10s experiment has more validity. It only enables interposition if e10s is enabled already.
Attachment #8704440 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8704371 [details] [diff] [review] fix-shims I'd like to land this patch on Aurora. It ensures that these prefs will be enabled in the next beta, with or without e10s. These prefs have been tested on Nightly and Aurora for many releases already.
Attachment #8704371 -
Flags: approval-mozilla-aurora?
Comment on attachment 8704440 [details] [diff] [review] change-default Taking it because it's needed to get e10s add-on telemetry data for FF45, beta44+
Attachment #8704440 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Assignee | ||
Comment 13•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/9cc90fb04ea6
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9cc90fb04ea6
status-b2g-v2.5:
--- → fixed
Comment 15•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a2a9829434d3
Status: NEW → RESOLVED
Closed: 8 years ago
status-b2g-v2.5:
fixed → ---
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 16•8 years ago
|
||
Comment on attachment 8704371 [details] [diff] [review] fix-shims aurora too
Attachment #8704371 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 17•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d295cbbdaf5d
Hi Bill, could you please backout the patch we landed in this bug to enable the e10s experiment? We've agreed to postpone this experiment from Fx44 to Fx45 beta cycle. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1238802#c10. Thanks!
Flags: needinfo?(wmccloskey)
https://hg.mozilla.org/releases/mozilla-beta/rev/0fb284f39677
Flags: needinfo?(wmccloskey)
Comment 20•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in
before you can comment on or make changes to this bug.
Description
•