1237264 - passing invalid json when updating a permission causes the field to become null

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

This is pretty bad, as a simple typo can end up granting wider access than intended. The permissions update/create endpoints should be throwing errors about this rather than silently accepting it.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: fix error showing for permissions

Details in PR.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: fix options handling/validation

Details in PR.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/9a9142540c4890784905d70a381245f6fddb1f4a
Merge pull request #43 from bhearsum/options-loss

bug 1237264: passing invalid json when updating a permission causes the field to become null

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8707074 [details] [review]
fix options handling/validation

Landed both patches here. Will go to prod after a few other changes have been queued up.

Comment 5

[[e-mail] (:bhearsum)]

This went to production today, because I had to fix up an unfinished push from last week.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/73c457b73a0862b03f7b2c5fbeee382f7f563d3d
[balrog-ui] Merge pull request #15 from bhearsum/permission-error

bug 1237264: Fix error showing when updating permissions.

https://github.com/mozilla/balrog/commit/af33f3722b264f6241308b8c6bded8759cc42525
[balrog-ui] Rebuild UI to pick up bug 1237264.