Closed Bug 1237270 Opened 8 years ago Closed 8 years ago

Cached page in offline mode doesn't show when switching back from Readerview

Categories

(Firefox for Android Graveyard :: Reader View, defect)

defect
Not set
normal

Tracking

(firefox46 affected)

RESOLVED INVALID
Tracking Status
firefox46 --- affected

People

(Reporter: barbara, Unassigned)

References

Details

1. Opened tab in Fennec online
2. Subway, no reception, opened tab again
3. Switched to reader view, page loaded, switched back to non-readerview via reader view icon, network error page occurred

Nexus 5, Android M., Nightly
I would think the non-reader page should be in the bfcache. Is that different than the cache we're using for the offline behavior added in bug 935190? 

First step would be to see if that offline logic is firing properly.

Alternately, we could add logic to the reader view button to see if the original URL is the previous URL in session history, and go back, rather than trying to load a new URL. However, if we change this, we'd probably want to look at changing the UX for desktop as well, since right now that does the same thing.
(In reply to Barbara Bermes [:barbara] from comment #0)
> 1. Opened tab in Fennec online
> 2. Subway, no reception, opened tab again
> 3. Switched to reader view, page loaded, switched back to non-readerview via
> reader view icon, network error page occurred
> 
> Nexus 5, Android M., Nightly

Do we know in #2 if the page was really cached? Try to "reload" the page using the 3-dot menu. If it's in the cache, it should be displayed.

Note: You can do #3 without a cached page, since the reader code just uses the existing DOM.

Since you hit the network error page when going back (in #3) I have to assume the page was never in the cache.
Based on followup talk, this seems to be working as expected.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.