Closed
Bug 1237295
Opened 8 years ago
Closed 8 years ago
TEST-UNEXPECTED-ERROR | test_places.py TestPlaces.test_plugins | NameError: global name 'errors' is not defined
Categories
(Testing :: Firefox UI Tests, defect, P1)
Tracking
(firefox43 fixed, firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox-esr38 unaffected)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
firefox44 | --- | fixed |
firefox45 | --- | fixed |
firefox46 | --- | fixed |
firefox-esr38 | --- | unaffected |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Something changed in Firefox Nightly which caused a hidden problem be raised: 06:55:58 INFO - Traceback (most recent call last): 06:55:58 INFO - File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run 06:55:58 INFO - testMethod() 06:55:58 INFO - File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/tests/test_places.py", line 66, in test_bookmarks 06:55:58 INFO - self.places.restore_default_bookmarks() 06:55:58 INFO - File "/home/mozauto/jenkins/workspace/mozilla-central_functional/build/venv/local/lib/python2.7/site-packages/firefox_puppeteer/api/places.py", line 105, in restore_default_bookmarks 06:55:58 INFO - raise errors.MarionetteException("Restore Default Bookmarks failed") The issue is here: https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/api/places.py#L8 https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/api/places.py#L105 We import the error classes directly but when raising an exception we use the errors module as prefix.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8704687 -
Flags: review?(mjzffr)
Attachment #8704687 -
Flags: review?(mjzffr) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Merged PR to mozilla-central branch as: https://github.com/mozilla/firefox-ui-tests/commit/b4af4d8dcc84c9d5d43d44ff25671d040920cbb1 It's not a bustage on other branches yet, so I will backport this later today or tomorrow.
Assignee | ||
Updated•8 years ago
|
Target Milestone: --- → Firefox 46
Assignee | ||
Comment 3•8 years ago
|
||
I also updated the python_packages branch for this change by rebasing it against mozilla-central.
Assignee | ||
Updated•8 years ago
|
Keywords: intermittent-failure
Updated•8 years ago
|
Product: Mozilla QA → Testing
Assignee | ||
Comment 4•8 years ago
|
||
Backports for other affected branches: https://github.com/mozilla/firefox-ui-tests/commit/6570a995800dcbca56abc8be449614ab837355dd (aurora) https://github.com/mozilla/firefox-ui-tests/commit/58cf08105f8e10bca1d51a2ad3c69a929cdd32c8 (beta) https://github.com/mozilla/firefox-ui-tests/commit/fe145ef9d823865efcd2610ac92325493ed6d645 (release)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•