1237808 - Include asyncCaller when iterating rejection frames

Status: NEW

(Toolkit :: Async Tooling, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Some parts of our code now join two sides of an async operation into one stack with things like Cu.callFunctionWithAsyncStack.

By checking the `asyncCaller` part of a stack, we can continue across the async barrier when reporting rejection stacks.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1237808 - Include asyncCaller when iterating rejection frames. r=Yoric

Review commit: https://reviewboard.mozilla.org/r/29953/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29953/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8705381 [details]
MozReview Request: Bug 1237808 - Include asyncCaller when iterating rejection frames. r=Yoric

https://reviewboard.mozilla.org/r/29953/#review26819

::: toolkit/modules/Promise-backend.js:197
(Diff revision 1)
> -            stack = stack.caller;
> +            stack = stack.asyncCaller || stack.caller;

Mmmmh.... Is it really `asyncCaller` when we're trying to remove top frames?

It would be great if you had a test for that.