1237901 - Intermittent browser_perf-overview-selection-02.js,browser_perf-recording-selected-03.js,browser_perf-refresh.js,browser_perf-details-06.js,browser_perf-console-record-06.js | application crashed [@ GeckoSampler::ToJSObject(JSContext *,double)]

Status: RESOLVED WORKSFORME

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Phil Ringnalda (:philor)]

+++ This bug was initially created as a clone of Bug #1234748 +++

+++ This bug was initially created as a clone of Bug #1234574 +++

+++ This bug was initially created as a clone of Bug #1221975 +++

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

What is this GeckoSample::ToJSObject failure? It's been blowing up the trees: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1237901&hide_resolved=1

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Seems to be turning the samples into a JS object to hand over to API consumers. I'm not familiar with this code.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Pinging BenWa

Comment 4

[Shu-yu Guo [:shu]]

Is there a stack? Could I get some links to failures?

Comment 5

[Phil Ringnalda (:philor)]

Only stale ones.

It's an assertion failure, "Assertion failure: (JS_ParseJSON(aCx, static_cast<const char16_t*>(js_string.get()), js_string.Length(), &val)), at c:/builds/moz2_slave/fx-team-w32-d-0000000000000000/build/src/tools/profiler/core/GeckoSampler.cpp:409", no idea why we filed it as a crash rather than an assertion failure, which appears to have been fixed around the 13th, which would make you think http://hg.mozilla.org/mozilla-central/rev/28a2f47fced8 except... can't be.

Most recent ones which are not misstars seem to be https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=3742454, https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=3746904, https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=3739127, https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=6579954, https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=19616970

Comment 6

[Phil Ringnalda (:philor)]

We'll catch you on the next one.