Closed Bug 1238000 Opened 8 years ago Closed 6 years ago

interdiff fails totally if previous version removed a file but the next one has it

Categories

(MozReview Graveyard :: General, defect, P3)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: smaug, Unassigned)

References

Details

(Whiteboard: [to be fixed in core]) 

https://reviewboard.mozilla.org/r/29831/diff/1-2/

v1 removed file_fullscreen-api-keys.html
v2 has that file with some changes to the original code.
All mozreview tells is that file was deleted.

This might be just a variant of mozreview not dealing with file removes.
This is dataloss and can erode the quality of a review. This should probably be high-priority for fixing.
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #1)
> This is dataloss and can erode the quality of a review. This should probably
> be high-priority for fixing.

Definitely. This is certainly a Review Board core bug around interdiffs, I'll take a look into this.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Priority: -- → P1
I've filed a core bug (https://hellosplat.com/s/beanbag/tickets/4052/) for taking care of this.
URL: https://hellosplat.com/s/beanbag/tick...
Whiteboard: [to be fixed in core]
Product: Developer Services → MozReview
Blocks: 1255654
See Also: → 1273385
Priority: P1 → P3
Assignee: smacleod → nobody
Status: ASSIGNED → NEW
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.