Closed
Bug 1238014
Opened 8 years ago
Closed 8 years ago
Improve code of firefox-ui-tests module based on marionette.py
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox45 fixed, firefox46 fixed)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
5.24 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
I can see some improvements we can / have to do for our firefox-ui-tests module and the release update script. This bug will cover that.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8705727 -
Flags: review?(ahalberstadt)
Comment 2•8 years ago
|
||
Comment on attachment 8705727 [details] [diff] [review] Patch v1 Review of attachment 8705727 [details] [diff] [review]: ----------------------------------------------------------------- I'm not a fan of using super unless it's absolutely necessary. See here for an explanation why: https://fuhm.net/super-harmful/ I know that not using it requires a bit more typing, but I think being explicit is more valuable, especially when there are as many mixins are there are in mozharness. ::: testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py @@ +226,5 @@ > 'abs_reports_dir': os.path.join(abs_dirs['base_work_dir'], 'reports'), > + 'abs_test_install_dir': os.path.join(abs_dirs['abs_work_dir'], 'tests'), > + } > + > + for key in dirs.keys(): nit: for key in dirs:
Attachment #8705727 -
Flags: review?(ahalberstadt) → review-
Assignee | ||
Comment 3•8 years ago
|
||
I talked with Andrew on IRC and pointed him to the following URL which shows that mozharness makes complete usage of super(). So I would like to follow that schema. http://mxr.mozilla.org/mozilla-central/search?string=super&find=testing/mozharness Andrew agreed on it. I will update the patch for the other nit even also that was a copy/paste from marionette.py.
Updated•8 years ago
|
Attachment #8705727 -
Flags: review- → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c7d85d6d0026
Assignee | ||
Comment 6•8 years ago
|
||
Currently we run our tests in mozmill-ci via the mozilla-central version of mozharness. But this might change for the 45ESR branch. I don't want to keep backward-compat code around for more than a year. So lets get the mozharness changes uplifted for 45: https://hg.mozilla.org/releases/mozilla-aurora/rev/ec2bd9b72622
status-firefox45:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•