Closed Bug 1238287 Opened 8 years ago Closed 3 years ago

Searchbar causes 25% CPU consumption and doesn't show suggestions after specific steps (userstory)

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox46 --- affected

People

(Reporter: arni2033, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [fxsearch] investigation)

User Story

This is so huge I'm going to post 1 str per comment. I provided Results in comment 6.
"Note" explains why it's better to have <= 3 search providers to reproduce this.
Screencasts of Steps 1-5:
> STR_1, non-e10s:   https://dl.dropboxusercontent.com/s/isqud1qjrf7kta2/0_2015.12.24%2008-02-46%20srarchbar%20-%20CPU%20pikes.webm?dl=0
> STR_6, non-e10s:   https://dl.dropboxusercontent.com/s/67b30o8po9cem1z/0_2015.12.24%2008-11-46%20srarchbar%20-%20CPU%20pikes.webm?dl=0

I'll provide full screencasts if it's necessary.
>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160107030235
STR_1 [non-e10s]:
0. Move searchbar to Toolbar, Open new window
1. Open   about:customizing   in a new tab
2. Press Ctrl+T to open new tab
3. Type "a" in Searchbar
4. Press Ctrl+Shift+T to switch to Customize tab
5.A) Press Escape to exit Customize
5.B) Hover mouse over any "One Off Button" (alternate search engines)
6. Click anywhere on the content on the page
7. Open new tab
8. Type "b" in Searchbar
STR_2 [non-e10s]:
0. Move searchbar to Toolbar, Open new window
1. Open   http://example.org   in a new tab
2. Type "a" in Searchbar
3. Place mouse over the magnifier icon, Hold left and right mouse buttons, Release left mouse button, Release right mouse button
4. Click "Customize..." in context menu
5.A) Press Escape to exit Customize
5.B) Hover mouse over any "One Off Button" (alternate search engines)
6. Click anywhere on the content on the page
7. Open new tab
8. Type "b" in Searchbar

This looks connected to bug 1190311
STR_3 [e10s, non-e10s]:
0. Move searchbar to Toolbar, Open new window
1. Open   http://example.org   in a new tab
2. Type "a" in Searchbar
3. Place mouse over the magnifier icon, Hold right mouse button, press Down key twice, Release right mouse button
4. Click "Move to Menu" in context menu
5. Hover mouse over any "One Off Button" (alternate search engines)
6. Click anywhere on the content on the page
7. Open new tab
8. Press Ctrl+K, Type "b" in Searchbar

This looks connected to bug 1190311
STR_4 [e10s, non-e10s]:
0. Move searchbar to Menu, Open new window
1. Open   http://example.org   in a new tab
2. Press Ctrl+K, type "a" in Searchbar
3. Do nothing
4. Right-click the magnifier icon
5. Click "Customize..." in context menu
6. Click anywhere on the page content
7. Open new tab
8. Press Ctrl+K, type "b" in Searchbar

This looks connected to bug 1198156
STR_5 [non-e10s]:
0. Move searchbar to Menu, Open new window
1. Open   http://example.org   in a new tab
2. Press Ctrl+K, type "a" in Searchbar
3. Do nothing
4. Do nothing
5. Click "Customize" button in Australis menu (it's very easy if suggestions popup opens above the searchbar)
6. Click anywhere on the content on the page
7. Open new tab
8. Press Ctrl+K, type "b" in Searchbar

This looks connected to bug 1198156, because it's all is a XUL issue
STR_6 [e10s, non-e10s]:
0. Move searchbar to Menu, Open new window
1. Open   http://example.org   in a new tab
2. Press Ctrl+K, type "a" in Searchbar
3. Do nothing
4. Right-click the magnifier icon
5. Click "Move to toolbar" in context menu
6. Click anywhere on the page content
7. Open new tab
8. Press Ctrl+K, type "b" in Searchbar

This looks connected to bug 1198156
Results:       
 After Step 3 search suggestions are displayed under search bar
 After Step 4 suggestions popup is still displayed untouched
 After Step 5 suggestions popup teleports to the bottom-left corner of the screen
              CPU consumption jumps to 25% and stays at that rate
 After Step 6 suggestions popup finally disappears
 After Step 8 the popup is displayed, but search suggestions area in popup is collapsed, so
              no suggestions are visible

Expectations: 
 (1) No increased CPU consumption     (2) Visible search suggestions
 (3) No popup teleportation, please   (4) No popup after Step 4
 
Note:
 The suggestions area isn't simply collapsed no matter what after Step 8. If I try this STR using a
 page with several search providers in Step 2 instead of New Tab Page, then it becomes clear that
 the popup only collapses it's current suggestions area and sets new constant height of the whole
 popup. I can provide detailed STR/screencast of that.
See Also: → 1251977
Keywords: perf
investigate with bug 1251977
Priority: -- → P2
Whiteboard: [fxsearch] investigation
Depends on: 1251977
Priority: P2 → P3

Hi, I think that this bug has been fixed. If I'm mistaken, please reopen it.
Regards, Flor.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.