1238289 - Remove unneeded stylesheet links in XUL files

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

While working with DOMi I see always rules applied multiple times. For example the .plain rule is applied 5 times with Lightning enabled. Without Lightning it's only 2 times (I don't know yet why 2 times but I want to reduce it also to 1 time in a TB bug).

I see <?xml-stylesheet type="text/css" href="chrome://global/skin/global.css"?> applied in multiple XUL files also when they aren't really needed because this files are running in a messenger window which has already linked to global.css.

I don't know if this removal would speed up things but I can imagine this is using lesser memory.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noStylesheet.patch

I checked the rules with this elements:
chrome://global/skin/global.css -> .plain in tree
chrome://calendar/content/calendar-view-bindings.css -> calendar-list-tree
chrome://calendar/skin/widgets/calendar-widgets.css -> treenode-checkbox
chrome://calendar/skin/today-pane.css -> #today-pane-panel
chrome://calendar-common/skin/widgets/minimonth.css -> minimonth

I removed the links from files which don't have a direct connection to the link. Like in messenger-overlay-sidebar.xul I removed almost all links and let them for example in today-pane.xul the link to today.css.

I also saw lightning-standalone.xul is never used and removed it. This was added in bug 293563 which was WONTFIXed later.

Comment 2

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/9df83b8b00ed0ac0fafa430041254f9eb8282a07
Bug 1238289 - Remove unneeded stylesheet links in XUL files. r=Fallen