Closed
Bug 1238507
Opened 8 years ago
Closed 6 years ago
Convert necko test binaries to cppunittests
Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-would-take])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Details |
Some of the necko GeckoSimplePrograms, while still compile, haven't been run in a long time. We should either convert them to CppUnitTests, or remove them.
Assignee | ||
Comment 1•8 years ago
|
||
- TestServ now includes code copied over from TestStreamLoader, to test the server unattended - Tests may still take optional command line arguments, if we wish to run them manually Review commit: https://reviewboard.mozilla.org/r/30313/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30313/
Attachment #8706317 -
Flags: review?(mcmanus)
Comment 2•8 years ago
|
||
Valentin, don't forget we also have gtests. Might be worth considering to convert rather to those.
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27456387ef42
Comment 4•8 years ago
|
||
Comment on attachment 8706317 [details] MozReview Request: Bug 1238507 - Convert necko test binaries to cppunittests r?mcmanus https://reviewboard.mozilla.org/r/30313/#review27025 try is busted r- honza's comment is valid - I would also add that you should feel free to delete tests that aren't being run and don't have any value in your judgment. but I'll take this (updated) patch because I'll always take incremental progress. thanks!
Attachment #8706317 -
Flags: review?(mcmanus)
Updated•8 years ago
|
Whiteboard: [necko-would-take]
Assignee | ||
Comment 5•8 years ago
|
||
The patch in bug 1288301 can be used as a model to convert the rest of the tests.
Comment 6•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
Assignee | ||
Comment 7•6 years ago
|
||
No longer applies. We no longer have binary tests - all have been converted to gtest.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•