1239074 - l10n nightlies don't find nsis

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

bug 1237040 updated nsis, and the l10n nightlies started to be burned.

The logs start with 

PATH=C:\mozilla-buildnsis-3.0b1;C:\mozilla-buildnsis-2.46u;C:\mozilla-buildpython27;C:\

and likely point to https://dxr.mozilla.org/build-central/search?q=nsis&redirect=true&case=false not enforcing a trailing slash.

Not that I know why it wasn't broken before, tbh.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Pretty sure this worked before because further down in the PATH variable, there are working references for 2.46u and 3.0a2 as set by MozillaBuild, which were both allowable versions to be used. However, rstrong's patch now enforces a minimum version of 3.0b1, so neither the 2.46u or 3.0a2 versions found further down are able to satisfy the requirement.

I'm about to attach a patch that fixes the trailing slashes, which should allow 3.0b1 to be found successfully.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Fix trailing slashes in config.py

My theory is bolstered by the fact that thunderbird_config.py already does the same as this patch is doing. While I'm at it, I'm also removing the obsolete reference to NSIS 2.46u. MozillaBuild still sets it further down, so it's entirely redundant having it here as well.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

From the PATH Axel pasted into channel a bit earlier, it looks like puppet (or something else) is already setting the python27 and buildbotve paths correctly as well later on. I'm wondering if we should just drop those while we're at it.

Is it a safe assumption to make that all Windows builders are running puppet at this point?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Fix trailing slashes in config.py

As per our discussion on IRC, this patch punts on dropping 2.46u from the path for now to minimize risk. The longer-term solution is probably to drop PATH setting from config.py and let mozharness/puppet/tooltool install packages and modify as-needed, but that's fodder for another bug.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8707519 [details] [diff] [review]
Fix trailing slashes in config.py

https://hg.mozilla.org/build/buildbot-configs/rev/388b403428e2

Comment 6

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/388b403428e2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Trunk Windows l10n nightlies are green on Treeherder. Looks like it worked :)