1239208 - Intermittent e10s browser_rules_edit-property-computed.js | Computed value of padding-top is as expected - Got 10px, expected 20px and several more

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=19696871&repo=mozilla-inbound

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* fx-team: 2
* b2g-inbound: 1

Platform breakdown:
* windows7-32: 4
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239208&startday=2016-01-11&endday=2016-01-17&tree=all

Comment 2

[Intermittent Failures Robot]

53 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 25
* mozilla-inbound: 18
* b2g-inbound: 5
* try: 3
* mozilla-central: 2

Platform breakdown:
* linux32: 32
* linux64: 16
* windows7-32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239208&startday=2016-01-18&endday=2016-01-24&tree=all

Comment 3

[Sami Jaktholm]

Attachment: bug-1239208-intermittent-rules-edit-property-computed.patch

Here's a patch. The logs show [1] how the setRuleText() from the inplace-editor commit is still pending when the test ends so the reason outlined in the commit message is likely the cause of the intermittents.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eda4aa68bf6

[1] https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=6934547#L9148

Comment 4

[Intermittent Failures Robot]

71 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 30
* fx-team: 25
* mozilla-central: 10
* try: 4
* b2g-inbound: 2

Platform breakdown:
* linux32: 47
* linux64: 19
* windows7-32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239208&startday=2016-01-25&endday=2016-01-31&tree=all

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 8713988 [details] [diff] [review]
bug-1239208-intermittent-rules-edit-property-computed.patch

Review of attachment 8713988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. Indeed, previewing a change does cause a ruleview-changed event, and waiting for this event is the right way of making sure there won't be pending requests when the test ends.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/eb673021691c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb673021691c

Comment 8

[Intermittent Failures Robot]

26 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 10
* mozilla-aurora: 7
* fx-team: 5
* try: 2
* mozilla-central: 2

Platform breakdown:
* linux32: 15
* linux64: 7
* windows7-32: 3
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239208&startday=2016-02-01&endday=2016-02-07&tree=all

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/74549922e503