1239244 - Highlight current page in revision dashboard page navigation

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Dashboards, enhancement)

Description

[Sebastian Zartner [:sebo]]

What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
https://developer.mozilla.org/en-US/dashboards/revisions?locale=&user=&topic=&start_date=&end_date=&preceding_period=&page=6 should somehow highlight that the navigation is at page 6, maybe also remove the link for the current page.

What problems would this solve?
===============================
Make it easier to see at which page you are.

Who would use this?
===================
People looking at the revision history.

What would users see?
=====================
The number of the current page highlighted within the navigation.

What would users do? What would happen as a result?
===================================================
Only thing that might happen is that users may not click on the current page in the navigation anymore.

Is there anything else we should know?
======================================

Comment 1

[Jean-Yves Perrier [:teoli]]

Woah! I was about to file this very same bug later this morning!

Comment 2

[Sebastian Zartner [:sebo]]

What a coincidence! :-)

Sebastian

Comment 3

[Rob Hudson [:robhudson]]

If you look at the source the HTML already has a class (<li class="selected">) that could be used. This only needs some style applied to it.

Comment 4

[Stephanie Hobson [:shobson]]

No, the HTML is <li selected> not <li class="selected">, the CSS supports class="selected", I think there is something wrong with the HTML output :(

Comment 5

[Sebastian Zartner [:sebo]]

If I'm not mistaken, the culprit is this commit:
https://github.com/mozilla/kuma/commit/0f0a2aa993ecb4eddddb8691dc3ed4545a3da170

Sebastian

Comment 6

[Rob Hudson [:robhudson]]

(In reply to Sebastian Zartner [:sebo] from comment #5)
> If I'm not mistaken, the culprit is this commit:
> https://github.com/mozilla/kuma/commit/
> 0f0a2aa993ecb4eddddb8691dc3ed4545a3da170
> 
> Sebastian

Good find. You're right. In which case I'll assign to myself to fix. Thanks. :)

Comment 7

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/531c81a5303afc077750a47aa8018041fc6a2479
Fix bug 1239244 - Indicate current page in paginator

https://github.com/mozilla/kuma/commit/b72f99f3b847e2ab67918863efd9ce17b5628c9f
Merge pull request #3755 from mozilla/1239244-selected-page

Fix bug 1239244 - Indicate current page in paginator

r=jezdez

Comment 8

[Sebastian Zartner [:sebo]]

Testing it on the staging server I can confirm that it's working again. Thank you!

Sebastian