Closed
Bug 1239246
Opened 8 years ago
Closed 8 years ago
Do not ship Facebook Share button in Hello
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
VERIFIED
FIXED
Iteration:
46.3 - Jan 25
People
(Reporter: RT, Assigned: vidhuran2012)
Details
User Story
- Disable the Facebook button for shipped builds, but not for nightly/beta builds. Tech Checklist: - In prefs.js add a new preference e.g. loop.facebook.enabled. - Similar to the way the loop.CSP pref, have it guarded by an ifdef. Use LOOP_BETA for that. When LOOP_BETA is set, enabled is true. - In Makefile, look for where prefs.js is generated into the build and dist directories. Set LOOP_BETA for both (we can do it for both build+dist since the add-on that gets exported to AMO is a "beta", and the mozilla-central export will be managed separately) - Add code in the conversation window to only display the Facebook share button when loop.facebook.enabled is true.
Attachments
(1 file)
We implemented Facebook Share, this was not satisfactory since the Facebook share dialogue opens in a new tab (we want a pop-up) and defaults to sharing on the Facebook timeline (we want to default to "in a private message") Initial Facebook share bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1178304 The implementation of Facebook Send will fix this with bug 1239241 although we need to ensure that bug 1178304 does not get shipped (purpose of that bug).
Reporter | ||
Updated•8 years ago
|
Rank: 15
Priority: -- → P1
Comment 1•8 years ago
|
||
To clarify: we want to keep it on in nightly/beta builds for testing and further developement.
User Story: (updated)
Updated•8 years ago
|
Assignee: nobody → vidhuran2012
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8708000 -
Flags: review?(standard8)
Comment 3•8 years ago
|
||
Comment on attachment 8708000 [details] [review] [loop] Vidhuran:bug1239246-disable-fb-btn > mozilla:master Great work, that looks really good.
Attachment #8708000 -
Flags: review?(standard8) → review+
Comment 4•8 years ago
|
||
Thank you for working on this. https://github.com/mozilla/loop/commit/df9b3ac9740937bad40b4d56d56116f6edb94967 https://github.com/mozilla/loop/commit/9e2c5a59476fe58e3c1bc6a1799594e049a7ee17
Status: NEW → RESOLVED
Iteration: --- → 46.3 - Jan 25
Closed: 8 years ago
Resolution: --- → FIXED
Comment 5•8 years ago
|
||
Setting qe+ here to make sure that this feature is disabled on release 44.
Flags: qe-verify+
QA Contact: bogdan.maris
Comment 6•8 years ago
|
||
Verified that Facebook Share is not available on Firefox 44.0.2 across platforms (Windows 7 64-bit, Mac OS X 10.11.1 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•