1239354 - test_connection_asyncClose.js fails lint checks because of deprecated generator function usage.

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Comment 1

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1239354: Replace old-style generator function with star functions. r?asuth

Review commit: https://reviewboard.mozilla.org/r/30733/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30733/

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

https://reviewboard.mozilla.org/r/30731/#review27571

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8707498 [details]
MozReview Request: Bug 1239354: Replace old-style generator function with star functions. r?asuth

https://reviewboard.mozilla.org/r/30733/#review27573

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I'm very sorry about that; the eslint plugin in atom was throwing all kinds of errors because I use global eslint because of CSP reasons when I invoke atom against only a subtree of gaia.  I tried to globally install the mozilla plugin that was missing, but it's not published on npm, and mach didn't seem to have any magic available.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Andrew Sutherland [:asuth] from comment #4)
> I'm very sorry about that; the eslint plugin in atom was throwing all kinds
> of errors because I use global eslint because of CSP reasons when I invoke
> atom against only a subtree of gaia.  I tried to globally install the
> mozilla plugin that was missing, but it's not published on npm, and mach
> didn't seem to have any magic available.

mach eslint --setup will install the right plugins globally including the mozilla plugin.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2200adcf35b

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Dave Townsend [:mossop] from comment #5)
> mach eslint --setup will install the right plugins globally including the
> mozilla plugin.

Ahhhh!  Thank you!  I experienced argument-blindness for "./mach eslint --help" and missed it, and so just ran "./mach bootstrap" and "./mach eslint" each in the hope they'd do things.  (Count me as a vote for having "./mach eslint" prompt/suggest the setup automatically like how "./mach build" will aggressively intercede in certain cases.)

Comment 8

[Dave Townsend [:mossop]]

(In reply to Andrew Sutherland [:asuth] from comment #7)
> (In reply to Dave Townsend [:mossop] from comment #5)
> > mach eslint --setup will install the right plugins globally including the
> > mozilla plugin.
> 
> Ahhhh!  Thank you!  I experienced argument-blindness for "./mach eslint
> --help" and missed it, and so just ran "./mach bootstrap" and "./mach
> eslint" each in the hope they'd do things.  (Count me as a vote for having
> "./mach eslint" prompt/suggest the setup automatically like how "./mach
> build" will aggressively intercede in certain cases.)

Yeah I want to do that in bug 1239139 when I get chance.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2200adcf35b