1239363 - Failing to parse marionette.logging preference when it is not a string

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette fails to start when the marionette.logging preference isn’t a string:

06:44:13     INFO -  JavaScript error: resource://gre/components/marionettecomponent.js, line 63: TypeError: s.toLowerCase is not a function

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester

The marionette.logging preference used to have a boolean type.
To maintain backwards compatibility with earlier clients we keep accepting
boolean types as input.

Previously setting it to true meant you wanted all the logs, and this
change respects that.

Review commit: https://reviewboard.mozilla.org/r/30741/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30741/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8707510 [details]
MozReview Request: Bug 1239363 - Accept non-string types for marionette.logging pref; r=AutomatedTester

https://reviewboard.mozilla.org/r/30741/#review27543

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b28a5678774d

Comment 4

[Intermittent Failures Robot]

61 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 61

Platform breakdown:
* windows8-64: 10
* windows7-64: 10
* windowsxp: 5
* windows8-32: 5
* windows7-32: 5
* linux64: 5
* linux32: 5
* osx-10-9: 4
* osx-10-6: 4
* osx-10-11: 4
* osx-10-10: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239363&startday=2016-01-13&endday=2016-01-13&tree=all

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b28a5678774d

Comment 6

[Intermittent Failures Robot]

24 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 24

Platform breakdown:
* linux64: 6
* windows8-64: 4
* windows7-64: 4
* windowsxp: 3
* windows8-32: 3
* windows7-32: 3
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239363&startday=2016-01-14&endday=2016-01-14&tree=all

Comment 7

[Andreas Tolfsen ❲:ato❳]

FWIW the OrangeFactor issues here should be resolved by bug 1239371, which is now on inbound.

Comment 8

[Intermittent Failures Robot]

98 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 98

Platform breakdown:
* windows8-64: 18
* windows7-64: 18
* windows7-32: 11
* linux64: 11
* windows8-32: 10
* windowsxp: 8
* linux32: 6
* osx-10-9: 4
* osx-10-6: 4
* osx-10-11: 4
* osx-10-10: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239363&startday=2016-01-11&endday=2016-01-17&tree=all