1239506 - console formatter should format 'nan' as 'NaN'

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Corey Farwell]

For some reason, Firefox formats "not a number" value as 'nan' sometimes in the console. For the sake of consistency, this should probably be styled as 'NaN'.

https://github.com/whatwg/console/blob/master/NOTES.md#float-formatter


Firefox:

```
console.log("%f", "fo")
nan
```

Chrome:

```
console.log("%f", "fo")
NaN
```

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: console-nan.patch

Andrea, this fixes the problem but I'm not sure if it's the best option.  Switching to AppendFloat instead of AppendFormatString also fixes it but then I don't think we can keep the `mantissa` functionality.  FWIW the mantissa syntax isn't supported by Chrome or in the lastest spec: https://console.spec.whatwg.org/#formatting-no-ui

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8712345 [details] [diff] [review]
console-nan.patch

Review of attachment 8712345 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, flagging for review.  Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38c25d87584d

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: console-nan.patch

Actually, switched to AppendFloat for nan case to get rid of hardcoded string.  I'm assuming this behavior is defined across platforms, I guess try will show

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/24320d1e9d99

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24320d1e9d99

Comment 6

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 46.0a1 (2016-01-13) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Developer Edition 47.0a2!

Build ID: 20160323004040
User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0

Comment 7

[Kazi Nuzhat Tasnem]

I have reproduced this bug with Firefox nightly 46.0a1(build id:20160113030208)on
windows 7(64 bit)

I have verified this bug as fixed with Firefox aurora 47.0a2(build id:20160323004040)
User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0