Closed
Bug 1239754
Opened 8 years ago
Closed 8 years ago
Remove HashKeyRef
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
All of the simple cases that used this have been converted over to stable hash codes.
Attachment #8707974 -
Flags: review?(jcoppeard)
|
Assignee | |
Comment 1•8 years ago
|
||
Comment on attachment 8707974 [details] [diff] [review] remove_HashKeyRef-v0.diff Review of attachment 8707974 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/gc/Marking.h @@ -431,5 @@ > - return; > - TraceManuallyBarrieredEdge(trc, &key, "HashKeyRef"); > - map->rekeyIfMoved(prior, key); > - } > -}; On a personal note: \o/
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8707974 [details] [diff] [review] remove_HashKeyRef-v0.diff Review of attachment 8707974 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8707974 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90d3e54b42fd
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8d87127bc2383d2c9380f6af19b53752b9acf5 Bug 1239754 - Remove HashKeyRef now that all of its users are using stable hashing; r=jonco
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0592bf91ff21&selectedJob=15484259
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3d8d87127bc2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•