Closed
Bug 1239783
Opened 8 years ago
Closed 8 years ago
NewTabURL.override is deprecated so use aboutNewTabService.newTabURL instead
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
Bug 1204983 switched the API to aboutNewTabService.newTabURL
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8708001 [details] [review] [loop] Mardak:bug-1239783-newTabURL > mozilla:master Changes came from bug 1204983 comment 89
Attachment #8708001 -
Flags: review?(dmose)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8708001 [details] [review] [loop] Mardak:bug-1239783-newTabURL > mozilla:master Looks good to me; r=dmose
Attachment #8708001 -
Flags: review?(dmose) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
So... as abr noted in bug 1238682 comment 10, the deprecation warning has been removed by bug 1239085. Do we mark this bug as wontfix or invalid? Or perhaps just land it?
Depends on: 1239085
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 5•8 years ago
|
||
After reading through more of bug 1204983 leading to bug 1239085, I think abr's conclusion of keeping what we have now makes sense. In particular NewTabURL API was made for add-ons and will be kept around without deprecation warning, so loop as an add-on should use it.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(standard8)
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•