Closed
Bug 123984
Opened 23 years ago
Closed 21 years ago
Mac NSPR needs to call MPLibraryIsLoaded
Categories
(NSPR :: NSPR, defect, P1)
Tracking
(Not tracked)
RESOLVED
WONTFIX
4.2
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
References
Details
Attachments
(1 file)
846 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
Quinn sez (regarding use of MP APIs): Did you call MPLibraryIsLoaded to check that MP was up and running before making this call? MPLibraryIsLoaded is a macro that calls _MPIsFullyInitialized, which actually completes the initialisation of the MP library. If you don't call it you get all sorts of weird errors.
Comment 1•23 years ago
|
||
Not that it isn't a good idea to initialize a library before using it :-) but Quinn's comment was in response to someone having problems using the MP APIs under Mac OS 9.2 which I believe we (currently) don't do.
Updated•22 years ago
|
Priority: -- → P1
Target Milestone: --- → 4.2
Assignee | ||
Comment 2•22 years ago
|
||
MPLibraryIsLoaded() is a macro that both tests the presence of the MP library, and calls _MPIsFullyInitialized(). Since we only use the MP APIs on OS X, I added the call to InitCriticalRegion() such that it only gets called on X.
Comment 3•22 years ago
|
||
Comment on attachment 75499 [details] [diff] [review] Patch to call MPLibraryIsLoaded(); Do we really need to make this call on X?
Assignee | ||
Comment 4•22 years ago
|
||
That's what the docs say. Of course, it may be a no-op on X, but there should be no harm in calling it, and that way we're following the API.
Comment 5•22 years ago
|
||
Comment on attachment 75499 [details] [diff] [review] Patch to call MPLibraryIsLoaded(); r=wtc. Can you get the drivers approval?
Attachment #75499 -
Flags: review+
Comment 6•21 years ago
|
||
This bug is in the Mac Classic version of NSPR. Since we no longer support Mac Classic, marked the bug WONTFIX even though we already have a patch.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•