Closed
Bug 1240014
Opened 8 years ago
Closed 8 years ago
[e10s] Enable newtab tests in browser/base/content/test/newtab/
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 47
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(36 files)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&author=neil@mozilla.com&selectedJob=15463190 The issue with browser_newtab_enhanced.js has been fixed.
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=668e74d09b11
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8708347 -
Flags: review?(adw)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8708348 -
Flags: review?(adw)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8708349 -
Flags: review?(adw)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8708350 -
Flags: review?(adw)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8708351 -
Flags: review?(adw)
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8708352 -
Flags: review?(adw)
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8708353 -
Flags: review?(adw)
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8708354 -
Flags: review?(adw)
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8708355 -
Flags: review?(adw)
Assignee | ||
Comment 11•8 years ago
|
||
Attachment #8708356 -
Flags: review?(adw)
Assignee | ||
Comment 12•8 years ago
|
||
Attachment #8708357 -
Flags: review?(adw)
Assignee | ||
Comment 13•8 years ago
|
||
Attachment #8708358 -
Flags: review?(adw)
Assignee | ||
Comment 14•8 years ago
|
||
Attachment #8708359 -
Flags: review?(adw)
Assignee | ||
Comment 15•8 years ago
|
||
Attachment #8708360 -
Flags: review?(adw)
Assignee | ||
Comment 16•8 years ago
|
||
Attachment #8708361 -
Flags: review?(adw)
Assignee | ||
Comment 17•8 years ago
|
||
Attachment #8708362 -
Flags: review?(adw)
Assignee | ||
Comment 18•8 years ago
|
||
Attachment #8708363 -
Flags: review?(adw)
Assignee | ||
Comment 19•8 years ago
|
||
Attachment #8708364 -
Flags: review?(adw)
Assignee | ||
Comment 20•8 years ago
|
||
Attachment #8708365 -
Flags: review?(adw)
Assignee | ||
Comment 21•8 years ago
|
||
Attachment #8708366 -
Flags: review?(adw)
Assignee | ||
Comment 22•8 years ago
|
||
Attachment #8708367 -
Flags: review?(adw)
Assignee | ||
Comment 23•8 years ago
|
||
Attachment #8708368 -
Flags: review?(adw)
Assignee | ||
Comment 24•8 years ago
|
||
Attachment #8708369 -
Flags: review?(adw)
Assignee | ||
Comment 25•8 years ago
|
||
Attachment #8708370 -
Flags: review?(adw)
Assignee | ||
Comment 26•8 years ago
|
||
Attachment #8708371 -
Flags: review?(adw)
Assignee | ||
Comment 27•8 years ago
|
||
Attachment #8708372 -
Flags: review?(adw)
Assignee | ||
Comment 28•8 years ago
|
||
Attachment #8708373 -
Flags: review?(adw)
Assignee | ||
Comment 29•8 years ago
|
||
Attachment #8708374 -
Flags: review?(adw)
Assignee | ||
Comment 30•8 years ago
|
||
Attachment #8708375 -
Flags: review?(adw)
Assignee | ||
Comment 31•8 years ago
|
||
Attachment #8708376 -
Flags: review?(adw)
Assignee | ||
Comment 32•8 years ago
|
||
Attachment #8708377 -
Flags: review?(adw)
Assignee | ||
Comment 33•8 years ago
|
||
Attachment #8708378 -
Flags: review?(adw)
Assignee | ||
Comment 34•8 years ago
|
||
Attachment #8708379 -
Flags: review?(adw)
Assignee | ||
Comment 35•8 years ago
|
||
Attachment #8708381 -
Flags: review?(adw)
Assignee | ||
Comment 36•8 years ago
|
||
Attachment #8708382 -
Flags: review?(adw)
Assignee | ||
Comment 37•8 years ago
|
||
I removed the code which attempted to do native drag/drop. I don't really see the point of a half-baked attempt at it when just sending the dragstart and drop events manually tests what is needed just fine. So I suspect these tests will work again and will see in an upcoming try build.
Assignee | ||
Updated•8 years ago
|
Attachment #8708384 -
Attachment description: Enable intermittent failure/10.10 tests → Patch 36 - Enable intermittent failure/10.10 tests
Assignee | ||
Comment 38•8 years ago
|
||
Also note that there are still a couple of cpow usages left to be cleaned up later: - one reference in browser_newtab_background_captures.js - the window sizing done near the top of head.js
Assignee | ||
Comment 39•8 years ago
|
||
Comment on attachment 8708384 [details] [diff] [review] Patch 36 - Enable intermittent failure/10.10 tests Try build (see comment 1) seems to be ok.
Attachment #8708384 -
Flags: review?(adw)
Updated•8 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Updated•8 years ago
|
Attachment #8708347 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708348 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708349 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708350 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708351 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708352 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708353 -
Flags: review?(adw) → review+
Comment 40•8 years ago
|
||
Comment on attachment 8708354 [details] [diff] [review] Patch 8 - enable test browser_newtab_bug752841 in e10s Review of attachment 8708354 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/newtab/browser_newtab_bug752841.js @@ +3,5 @@ > > const PREF_NEWTAB_ROWS = "browser.newtabpage.rows"; > const PREF_NEWTAB_COLUMNS = "browser.newtabpage.columns"; > > +function getCellsCount() function* ?
Attachment #8708354 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708355 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708356 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708357 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708358 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708359 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708360 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708361 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708362 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708363 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708364 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708365 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708366 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708367 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708368 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708369 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708370 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708371 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708372 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708373 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708374 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708375 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708376 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708377 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708378 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708379 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708381 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708382 -
Flags: review?(adw) → review+
Updated•8 years ago
|
Attachment #8708384 -
Flags: review?(adw) → review+
Assignee | ||
Comment 41•8 years ago
|
||
> > const PREF_NEWTAB_ROWS = "browser.newtabpage.rows";
> > const PREF_NEWTAB_COLUMNS = "browser.newtabpage.columns";
> >
> > +function getCellsCount()
>
> function* ?
This function isn't a generator.
Assignee | ||
Comment 42•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/74f9e7722a5523430e172c637a2b84d5999fd6cd Bug 1240014, enable test browser_newtab_bug998387 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/2dad2d6029b8c20c3000f895e7952ec4234ac1bb Bug 1240014, enable test browser_newtab_bug991111 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/0eaebe7b38c44a22eb37d19329edf1c228997d8c Bug 1240014, enable test browser_newtab_focus in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/1edbbf144990fdaf176ec0e6b0455880aa8ed37a Bug 1240014, enable test browser_newtab_1188015 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/cc7b8d6c1d03467f5884eaf73ad5871b6c8d2568 Bug 1240014, enable test browser_newtab_sponsored_icon_click in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e24f63006964539cd2589d4bb070dfead5ed63 Bug 1240014, enable test browser_newtab_bug991210 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2d71ad9d983adb9a3a9733d795095c51c44473 Bug 1240014, enable test browser_newtab_bug723102 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/80879e1c8b7f5ccef173ddd132b99ef587820ea0 Bug 1240014, enable test browser_newtab_bug752841 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/bec26e4948a4587b7315562788b8a3fe0a8bbeff Bug 1240014, enable test browser_newtab_bug721442 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/2b79f3d62e3fe76609867940f1ce2db7323496c7 Bug 1240014, enable test browser_newtab_bug723121 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/fcde120f53ec7beca1330f1237c2e4af72f20d0f Bug 1240014, enable test browser_newtab_bug765628 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/fce6fae4b39f80366dc3770054e751d1a1db3dff Bug 1240014, enable test browser_newtab_disable in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/4f63fac38e6b519bcd1f1c475d2f0c5346e956d8 Bug 1240014, enable test browser_newtab_block in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/f2adb435f34d18932b96a95e843fd6a3a8c57dfd Bug 1240014, enable test browser_newtab_unpin in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/9d1d7aec4dd0185c3f457777fb26e2ecb9bc1faa Bug 1240014, enable test browser_newtab_bug876313 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f52a5caf79ac58b753b16894439348243c1af3 Bug 1240014, enable test browser_newtab_bug1178586 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/2e93b0d93840dfb5fe3ae32e9f2c03f6bd0799ff Bug 1240014, enable test browser_newtab_bug1145428 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/4568d6d819050b5a4572dfec83bb917fd5cac42c Bug 1240014, enable test browser_newtab_bug722273 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f25869bc40c4bf7385e3729799262b86161c85 Bug 1240014, enable test browser_newtab_update in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/d1387e1ee26e056b2f79fb6bd25680ce6dbb1b05 Bug 1240014, enable test browser_newtab_bug734043 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/97a0741985f20a27f5c15eadd2a3352edd22efeb Bug 1240014, enable test browser_newtab_undo in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe0380c25b72abc39623de2b01701d54b9c4827 Bug 1240014, enable test browser_newtab_reportLinkAction in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/c7de7b95563b23e7296f3178105323c2f8564730 Bug 1240014, enable test browser_newtab_perwindow_private_browsing in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/e71083fd76ca7d35e2398288635b637436725c32 Bug 1240014, enable test browser_newtab_bug725996 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/f81622d1b317147f1752a68dd9449d0b1413ba85 Bug 1240014, enable test browser_newtab_enhanced in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/ab48d7c75bb195373eb28fce2169aabe08798a2a Bug 1240014, enable test browser_newtab_search in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/b36c5e8a7b624a93cd36b347238daec3204bcaa6 Bug 1240014, enable test browser_newtab_drag_drop in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/1dbf15b69d9818fd254cb0d24244c4ee19c7699d Bug 1240014, enable test browser_newtab_drop_preview in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/77ef4985adb383ddf930dde3b8d02b5320423485 Bug 1240014, enable test browser_newtab_reflow_load in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/2b178fcf48b7eb2dd58fb2799706d1403426c196 Bug 1240014, enable test browser_newtab_external_resource in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/305a90067c4f256e3e97806ec5829c34a66da1a3 Bug 1240014, enable test browser_newtab_bug1194895 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/4284ad393395718a76e0b9b75a3d47a4ce32be5a Bug 1240014, enable test browser_newtab_drag_drop_ext in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/24168c5f294e69459876c78f3d6ace8c4f5bc746 Bug 1240014, enable test browser_newtab_bug735987 in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/5764ba83633cd4117d79d120703766c9ca1039bb Bug 1240014, enable test browser_newtab_background_captures in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a62dda9159b3bd2cfc25210962c1e834045d59 Bug 1240014, remove unused code in test/newtab/head.js and enable tests in e10s, r=adw https://hg.mozilla.org/integration/mozilla-inbound/rev/48a50b0597115a819e928469eed85271efda379d Bug 1240014, re-enable dragdrop tests on Mac, r=adw
Comment 43•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74f9e7722a55 https://hg.mozilla.org/mozilla-central/rev/2dad2d6029b8 https://hg.mozilla.org/mozilla-central/rev/0eaebe7b38c4 https://hg.mozilla.org/mozilla-central/rev/1edbbf144990 https://hg.mozilla.org/mozilla-central/rev/cc7b8d6c1d03 https://hg.mozilla.org/mozilla-central/rev/a8e24f630069 https://hg.mozilla.org/mozilla-central/rev/4a2d71ad9d98 https://hg.mozilla.org/mozilla-central/rev/80879e1c8b7f https://hg.mozilla.org/mozilla-central/rev/bec26e4948a4 https://hg.mozilla.org/mozilla-central/rev/2b79f3d62e3f https://hg.mozilla.org/mozilla-central/rev/fcde120f53ec https://hg.mozilla.org/mozilla-central/rev/fce6fae4b39f https://hg.mozilla.org/mozilla-central/rev/4f63fac38e6b https://hg.mozilla.org/mozilla-central/rev/f2adb435f34d https://hg.mozilla.org/mozilla-central/rev/9d1d7aec4dd0 https://hg.mozilla.org/mozilla-central/rev/a5f52a5caf79 https://hg.mozilla.org/mozilla-central/rev/2e93b0d93840 https://hg.mozilla.org/mozilla-central/rev/4568d6d81905 https://hg.mozilla.org/mozilla-central/rev/c5f25869bc40 https://hg.mozilla.org/mozilla-central/rev/d1387e1ee26e https://hg.mozilla.org/mozilla-central/rev/97a0741985f2 https://hg.mozilla.org/mozilla-central/rev/dfe0380c25b7 https://hg.mozilla.org/mozilla-central/rev/c7de7b95563b https://hg.mozilla.org/mozilla-central/rev/e71083fd76ca https://hg.mozilla.org/mozilla-central/rev/f81622d1b317 https://hg.mozilla.org/mozilla-central/rev/ab48d7c75bb1 https://hg.mozilla.org/mozilla-central/rev/b36c5e8a7b62 https://hg.mozilla.org/mozilla-central/rev/1dbf15b69d98 https://hg.mozilla.org/mozilla-central/rev/77ef4985adb3 https://hg.mozilla.org/mozilla-central/rev/2b178fcf48b7 https://hg.mozilla.org/mozilla-central/rev/305a90067c4f https://hg.mozilla.org/mozilla-central/rev/4284ad393395 https://hg.mozilla.org/mozilla-central/rev/24168c5f294e https://hg.mozilla.org/mozilla-central/rev/5764ba83633c https://hg.mozilla.org/mozilla-central/rev/f9a62dda9159 https://hg.mozilla.org/mozilla-central/rev/48a50b059711
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 44•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/a690fe95c17c https://hg.mozilla.org/releases/mozilla-aurora/rev/ad604879385d https://hg.mozilla.org/releases/mozilla-aurora/rev/b42e7d748db3 https://hg.mozilla.org/releases/mozilla-aurora/rev/7adcb3149fe1 https://hg.mozilla.org/releases/mozilla-aurora/rev/dbf5525b3d27 https://hg.mozilla.org/releases/mozilla-aurora/rev/10b3246c607d https://hg.mozilla.org/releases/mozilla-aurora/rev/9fe9222b03ed https://hg.mozilla.org/releases/mozilla-aurora/rev/c5f4b371741f https://hg.mozilla.org/releases/mozilla-aurora/rev/afd289cc98f0 https://hg.mozilla.org/releases/mozilla-aurora/rev/f574a8bb8a4c https://hg.mozilla.org/releases/mozilla-aurora/rev/9d548190fa57 https://hg.mozilla.org/releases/mozilla-aurora/rev/4d5614b68b60 https://hg.mozilla.org/releases/mozilla-aurora/rev/148e438f6150 https://hg.mozilla.org/releases/mozilla-aurora/rev/e2458e669a67 https://hg.mozilla.org/releases/mozilla-aurora/rev/4645c0ebf15c https://hg.mozilla.org/releases/mozilla-aurora/rev/9b40a719068e https://hg.mozilla.org/releases/mozilla-aurora/rev/5506de8c4ce3 https://hg.mozilla.org/releases/mozilla-aurora/rev/5379226058eb https://hg.mozilla.org/releases/mozilla-aurora/rev/7cc4d12fce75 https://hg.mozilla.org/releases/mozilla-aurora/rev/95e31a49f09e https://hg.mozilla.org/releases/mozilla-aurora/rev/e1ce93985cbf https://hg.mozilla.org/releases/mozilla-aurora/rev/936311ad5b10 https://hg.mozilla.org/releases/mozilla-aurora/rev/748cc92ed437 https://hg.mozilla.org/releases/mozilla-aurora/rev/50940a69a70c https://hg.mozilla.org/releases/mozilla-aurora/rev/8d765fbcb85f https://hg.mozilla.org/releases/mozilla-aurora/rev/1ce985391485 https://hg.mozilla.org/releases/mozilla-aurora/rev/47affe56784d https://hg.mozilla.org/releases/mozilla-aurora/rev/797b9316f8cf https://hg.mozilla.org/releases/mozilla-aurora/rev/277b772d5d64 https://hg.mozilla.org/releases/mozilla-aurora/rev/377ff561d926 https://hg.mozilla.org/releases/mozilla-aurora/rev/8e8be7ddb6e7 https://hg.mozilla.org/releases/mozilla-aurora/rev/849038fcdf9f https://hg.mozilla.org/releases/mozilla-aurora/rev/b4a6dc883595 https://hg.mozilla.org/releases/mozilla-aurora/rev/3d19c36da0ce https://hg.mozilla.org/releases/mozilla-aurora/rev/d9e5b282418f https://hg.mozilla.org/releases/mozilla-aurora/rev/fdf414057257
Comment 45•8 years ago
|
||
This bug appears to have caused a slew of new intermittents. Please fix or backout ASAP.
Flags: needinfo?(enndeakin)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(enndeakin)
You need to log in
before you can comment on or make changes to this bug.
Description
•