1240323 - Fix browser component installation for linux artifact builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Like bug 1239678, but for Linux (this isn't a problem for Mac builds).

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1240323 - Fix installation of binary components in a subdir of dist/bin for linux artifact builds. r=nalexander

A recent change regressed this behavior -- while an artifact build runs, it
doesn't load certain "about:" pages due to missing libraries in subdirectories
of dist/bin.

Review commit: https://reviewboard.mozilla.org/r/31149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31149/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8708723 [details]
MozReview Request: Bug 1240323 - Fix installation of binary components in a subdir of dist/bin for linux artifact builds. r=nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31149/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

Review commit: https://reviewboard.mozilla.org/r/31151/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31151/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #3)
> Created attachment 8708731 [details]
> MozReview Request: Bug 1240239 - Install test plugins in artifact based
> builds. r=nalexander
> 
> Review commit: https://reviewboard.mozilla.org/r/31151/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/31151/

Mozreview put this commit on the wrong bug :/

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8708723 [details]
MozReview Request: Bug 1240323 - Fix installation of binary components in a subdir of dist/bin for linux artifact builds. r=nalexander

https://reviewboard.mozilla.org/r/31149/#review27957

Thanks -- I should have checked whether we had Linux bustage when I saw the Windows bustage go by.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8708731 [details]
MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

https://reviewboard.mozilla.org/r/31151/#review27959

Do the plugins not get added to an install manifest, in the manner that the libraries and binaries get added to the `dist/bin` install manifest?  If so, roll on.

If not, address and land if you're confident or ask for re-review if you want it.  Thanks for squashing this.  Can you suggest a test case that uses a test plugin, and preferably a `mach test` command line, so that we can test this across platforms?

::: python/mozbuild/mozbuild/artifacts.py:96
(Diff revision 1)
> -    test_artifact_patterns = {
> +    test_binary_patterns = {

Can we unify these?  It sucks that we haven't grown a generic "from this pattern, to this pattern" yet, but perhaps we can do `(base, {patterns})` again.

If you think that's unwise, let's at least make sure that we have a set of patterns for plugins, and that we process all the entries of both sets as patterns (and not as direct matches).

::: python/mozbuild/mozbuild/mach_commands.py:1510
(Diff revision 1)
> -        retcode = artifacts.install_from(source, self.bindir, install_callback=install_callback)
> +        retcode = artifacts.install_from(source, self.distdir, install_callback=install_callback)

So unfortunate -- I narrowed to `bindir` in an earlier revision.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/31151/#review27959

Thanks for the speedy review. Right, there isn't a manifest for plugins in $objdir/_build_manifests/install.

Re: testing, see my comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1240239 (the command line I used was |./mach test testing/mochitest/chrome|). I'll address comments and re-request over there.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcdc710161b5

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcdc710161b5

Comment 10

[:Gijs (he/him)]

(sorry for not realizing linux needed updates, too, when fixing bug 1239678 :-( )