1240388 - Convert start-shell.bat to a shell script

Status: RESOLVED WONTFIX

(Firefox Build System :: MozillaBuild, task)

Description

[Biru [:poiru]]

I'd like to add msys\etc\profile.d\profile-env.sh, which would effectively do what start-shell.bat does now. While we're at it, we should drop our dependency on vsvars*.bat and manually set the paths similar to the automation mozconfigs[0].

RyanVM, what are your thoughts on this? Also, should we drop support for 32-bit host machines as well?

[0]: http://mxr.mozilla.org/mozilla-central/source/build/win32/mozconfig.vs2013-win64

Comment 1

[Ryan VanderMeulen [:RyanVM]]

My hero! This is exactly the direction I wanted to go in. I hate dealing with batch scripts and firmly believe that moving more of it over to a shell script would simplify life. I also believe we could kill profile-extravars.sh while we're at it if we go this route (and just add the needed functionality to profile-env.sh).

What's the rationale for dropping support for 32-bit host machines? FWIW, I'd also been thinking about adding a hard check for Win7+ in the NSIS installer (since VS2013 requires at least that anyway), but I've hesitated over the non-build use cases of MozillaBuild.

Comment 2

[Biru [:poiru]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)
> What's the rationale for dropping support for 32-bit host machines?

Mostly that we don't use them at all in automation for building Firefox. (And I can't test if I accidentally break 32-bit machines, although I guess someone will promptly complain in that case.)

Comment 3

[Biru [:poiru]]

ni? for decision about dropping 32-bit hosts. I'm fine either way.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Let's keep 32-bit support for now.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This bug as-filed is mostly WONTFIX at this point given that MozillaBuild is mostly EOL now. That said, now that start-shell-msvc*.bat is a thing of the past and a lot of what start-shell.bat does is now redundant, there's a lot of useful cleanups that could be done. But I think it'd be easier to track that in a new bug rather than re-purposing this one for it.