1240512 - Standalone no longer shows "Something went wrong" if the a server connection drops

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

STR:

1) Set up a local system whereby the server is running on localhost so that it can be killed (or a dev/production system where you can block access to a specific IP.
2) Set up a conversation
3) Kill the loop-server or the connection to it.
4) Watch the standalone UI and the error console.

Actual Results

Nothing happens on the UI
On the console: Type error: result is undefined activeRoomStore.js 1079

Expected Results

Something went wrong (or equivalent message is displayed).

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] Vidhuran:bug-1240512-standalone-xhr-fixes > mozilla:master

Comment 2

[Vidhuran Harichandra Babu]

I have made a patch for this. It is still needs some more work. 

The part that is not good about this patch is that, in some cases when the refreshMembership timeout is later than the data channel close event, the standalone view goes to the state when there are no participants and then when the refreshMembership happens it puts "Could not connect to server".

I see that there are todo comments in the part that handles close events on data channels. 
Should we handle those as well in this bug ?

Comment 3

[Mark Banner (:standard8)]

The issue with when refreshMembership isn't hit yet, but the sdk times out, is bug 1240517.

We'll deal with that there. I think the PR looks good in general, one minor nit commented on it.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8710391 [details] [review]
[loop] Vidhuran:bug-1240512-standalone-xhr-fixes > mozilla:master

r=Standard8 with the comment fixed.

Comment 5

[Vidhuran Harichandra Babu]

Comments fixed in the PR

Comment 6

[Mark Banner (:standard8)]

Great, thank you.

https://github.com/mozilla/loop/commit/720befbabc0a4a75093308f92e55a9d23c806f50