1240659 - Add GonkNativeHandle::CreateDupNhObj()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

GonkNativeHandle expects that it always owns fd of native_handle_t. But there is a case that the assumption is not met. To handle the case, it seems better to add a function that just dups a native_handle_t for GonkNativeHandle::NhObj.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GonkNativeHandle::CreateDupNhObj()

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GonkNativeHandle::CreateDupNhObj()

Add error handling.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GonkNativeHandle::CreateDupNhObj()

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GonkNativeHandle::CreateDupNhObj()

correct patch.

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8709305 [details] [diff] [review]
patch - Add GonkNativeHandle::CreateDupNhObj()

Review of attachment 8709305 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/GonkNativeHandle.cpp
@@ +42,5 @@
>  
>  already_AddRefed<GonkNativeHandle::NhObj>
>  GonkNativeHandle::GetDupNhObj()
>  {
> +  return GonkNativeHandle::CreateDupNhObj(mNhObj->mHandle);

IsValid() checks (mNhObj && mNhObj->mHandle). Does this mean that you may run in a crash if mNhObj is null here?

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] from comment #5)
> Comment on attachment 8709305 [details] [diff] [review]
> patch - Add GonkNativeHandle::CreateDupNhObj()
> 
> Review of attachment 8709305 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/ipc/GonkNativeHandle.cpp
> @@ +42,5 @@
> >  
> >  already_AddRefed<GonkNativeHandle::NhObj>
> >  GonkNativeHandle::GetDupNhObj()
> >  {
> > +  return GonkNativeHandle::CreateDupNhObj(mNhObj->mHandle);
> 
> IsValid() checks (mNhObj && mNhObj->mHandle). Does this mean that you may
> run in a crash if mNhObj is null here?

Oh, sorry it is my mistake. I am going to update the patch. It should not crash.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GonkNativeHandle::CreateDupNhObj()

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a24d6c2b7525

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a24d6c2b7525