Closed
Bug 1240730
Opened 8 years ago
Closed 8 years ago
Initialize all GLXLibrary symbols in the ctor to silence static analysis warnings
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 749989][CID 1123714])
Attachments
(2 files, 1 obsolete file)
|
2.26 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
|
2.50 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
These members are later properly set in EnsureInitialized which is called before any method that reads them, but there's no reason to leave them uninitialized in the constructor considering the annoying warning noise that it generates, and if a bug is introduced it'll be much easier to debug if we dereference nullptr than some random address.
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8709414 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Previously uploaded the wrong version of the patch.
Attachment #8709414 -
Attachment is obsolete: true
Attachment #8709414 -
Flags: review?(matt.woodrow)
Attachment #8709421 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8709458 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [CID 749989] → [CID 749989][CID 1123714]
|
||
Updated•8 years ago
|
Attachment #8709421 -
Flags: review?(matt.woodrow) → review+
|
|
||
Updated•8 years ago
|
Attachment #8709458 -
Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c940c4d4b17e https://hg.mozilla.org/integration/mozilla-inbound/rev/75104f84eda6
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c940c4d4b17e https://hg.mozilla.org/mozilla-central/rev/75104f84eda6
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•8 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•