Closed
Bug 1240867
Opened 8 years ago
Closed 8 years ago
Compile errors due to missing includes
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(2 files, 1 obsolete file)
2.47 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
1.84 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
I add a new file to the gfx/layers unified build and it caused bustage: c:/builds/moz2_slave/try-w32-mulet-0000000000000000/build/src/gfx/layers/client/ImageClient.cpp(326) : error C2664: 'void mozilla::layers::ShadowLayerForwarder::AttachAsyncCompositable(uint64_t,mozilla::layers::ShadowableLayer *)' : cannot convert argument 2 from 'mozilla::layers::ClientLayer *' to 'mozilla::layers::ShadowableLayer *' ImageClient.cpp doesn't know that ClientLayer is a subclass of ShadowableLayer because all it has is the forward declaration in ImageClient.h
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → bugmail.mozilla
Attachment #8709589 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•8 years ago
|
||
There's also this one: c:/builds/moz2_slave/try-w32-mulet-0000000000000000/build/src/gfx/layers/opengl/OGLShaderProgram.cpp(165) : error C2065: 'CompositionOp' : undeclared identifier because OGLShaderProgram.cpp isn't including gfx/2d/Types.h.
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8709591 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•8 years ago
|
Summary: Compile error due to missing include → Compile errors due to missing includes
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8709591 [details] [diff] [review] Part 2 - Another missing include This one doesn't seem to fix the error for some reason. Stupid un-locally-reproducible unified build bustages :(
Attachment #8709591 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 5•8 years ago
|
||
Ok, here we go.
Attachment #8709591 -
Attachment is obsolete: true
Attachment #8709599 -
Flags: review?(nical.bugzilla)
Updated•8 years ago
|
Attachment #8709589 -
Flags: review?(nical.bugzilla) → review+
Updated•8 years ago
|
Attachment #8709599 -
Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9b03a12ce6d https://hg.mozilla.org/integration/mozilla-inbound/rev/b7b536914def
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e9b03a12ce6d https://hg.mozilla.org/mozilla-central/rev/b7b536914def
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•