1241003 - Handle AudioData with 0 frames

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/b67316254602a63bf4e568198a5c7d3288a9db27/dom/media/mediasink/DecodedAudioDataSink.cpp#l236

It is possible for an AudioData to have 0 frames. We should ignore it and continue to process the next element to avoid silence.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6362113028d6

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1241003 - ignore AudioData with 0 frames to avoid silence. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/31905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31905/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8710897 [details]
MozReview Request: Bug 1241003 - ignore AudioData with 0 frames to avoid silence. r=kinetik.

https://reviewboard.mozilla.org/r/31905/#review28629

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/357a870647f2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/357a870647f2