Closed
Bug 1241301
Opened 8 years ago
Closed 8 years ago
Use PR_LogPrint in purplexpcom following Bug 1174972
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 46
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
14.77 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Bustage from bug 1174972: 56:51.14 Undefined symbols for architecture x86_64: 56:51.14 "mozilla::detail::log_print(PRLogModuleInfo const*, mozilla::LogLevel, char const*, ...)", referenced from: 56:51.14 purpleAccount::purpleAccount() in purpleAccount.o 56:51.14 purpleAccount::~purpleAccount() in purpleAccount.o 56:51.14 purpleAccount::Remove() in purpleAccount.o 56:51.14 purpleAccount::Init(imIAccount*, prplIProtocol*) in purpleAccount.o 56:51.14 purpleAccount::ApplyCurrentUserIcon() in purpleAccount.o 56:51.15 purpleAccount::Connect() in purpleAccount.o 56:51.15 purpleAccount::Disconnect() in purpleAccount.o We can resolve this similarly to how that bug handles netwerk/test, by redefining MOZ_LOG to use PR_LogPrint instead.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8710155 -
Flags: review?(clokep)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Comment on attachment 8710155 [details] [diff] [review] Use PR_LogPrint in purplexpcom following Bug 1174972 Works for me. The header ordering in those files is weird, but I don't have a comment on making them better.
Attachment #8710155 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/users/florian_queze.net/purple/rev/17fc639a64bd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 46
Comment 4•8 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #2) > The header ordering in those files is weird, but I don't have > a comment on making them better. FWIW, they used to be alphabetically ordered, with the " headers (local headers) and the <> headers (platform/system headers) grouped together. There may have been a few exceptions due to inclusion order constraints. And some more unintended exceptions.
You need to log in
before you can comment on or make changes to this bug.
Description
•