Closed Bug 1241432 Opened 8 years ago Closed 8 years ago

Implement GB18030-2005

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(1 file)

patch
9.15 KB, patch
smontagu
: review+
Details | Diff | Splinter Review 
To align with a recent change to Encoding Standard.
Attached patch patch — — Splinter Review 
According to bug 79275, GB18030 mapping tables are generated from "GB18030" file on unicode.org. But I could not regenerate mapping tables because apparently unicode.org does not provide this file anymore. So I hard-coded the mapping change.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8710414 - Flags: review?(smontagu)
Comment on attachment 8710414 [details] [diff] [review]
patch

Review of attachment 8710414 [details] [diff] [review]:
-----------------------------------------------------------------

The hardcoding is ugly, but it's probably the best alternative -- trying to reconstruct GB18030 from a mapping file from some other source would be riskier.
Attachment #8710414 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/d2004ed18467
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: