1241485 - Increase the limit for workers per-origin

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: a (non-mochi-) test

Currently we limit to 20 per domain (bug 649537) but that is rather low, definitely less than in other 
browsers. Chrome doesn't seem to have a limit, but it just makes child process crash when around 50 workers 
are created (linux), or hang for awhile and crash the child process with ~750 workers (Windows). 
IE11 on Win7 limits to 25, and I was told Edge on Win10 has limit at 25 too.

Bug 1052398 is a bit noisy about various different things, so if we just want to make a simple increase to 
the limit, this is the separate bug for that.

I do think any application using lots of workers should be expected to send back a notification from the 
worker when it is loaded and then it can know how many workers it has to play with.
In other words, I'm not really a fan of { throwOnCreation: true } proposal.

Based on the behavior Chrome has on linux, I'm proposing we increase the limit to 50.
I'll push a patch with a mochitest which creates as many workers as possible to tryserver in order to
verify nothing really bad starts to happen if limit is increased.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: worker_limit.diff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a87d54fc5f5

Comment 2

[Andrew Overholt [:overholt]]

Should we dupe bug 1222629 to this one?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +tweaks to the test

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25b129433679

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Desktop Safari seems to limit to 290 but it is not clear to me what kind of limit that is.
Not global and not per domain, but perhaps per top level window or something.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4697704ff426

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4697704ff426

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4697704ff426

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4697704ff426